Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️🌊 Support resolving non-rank-based metrics #1237

Merged
merged 105 commits into from
Sep 23, 2023
Merged

Conversation

mberr
Copy link
Member

@mberr mberr commented Mar 5, 2023

  • convert classification metrics into classes (parallel to rank-based metrics)
  • add side/prediction target support for classification metrics
  • introduce MetricKey base class, with ClassificationMetricKey and RankBasedMetricKey; those implement the conversion of strings into fully qualified metric keys (i.e., inferring defaults, and resolving synonyms and spelling variants)
  • annotate base Evaluator with generic metric key type - this allows static code analysis to check whether we use the correct key with the correct evaluator / evaluation results.

Fix #1235

@mberr
Copy link
Member Author

mberr commented Mar 5, 2023

It might make sense to move the metric resolution into the evaluator class. This avoids, e.g., that non-rank-based metrics resolve a rank-type.

@mberr mberr marked this pull request as ready for review September 22, 2023 22:16
@mberr mberr enabled auto-merge (squash) September 23, 2023 07:52
@mberr mberr disabled auto-merge September 23, 2023 08:33
@mberr mberr enabled auto-merge (squash) September 23, 2023 08:48
@cthoyt cthoyt enabled auto-merge (squash) September 23, 2023 09:01
@mberr mberr disabled auto-merge September 23, 2023 12:31
@mberr mberr enabled auto-merge (squash) September 23, 2023 12:31
@mberr mberr marked this pull request as draft September 23, 2023 13:31
auto-merge was automatically disabled September 23, 2023 13:31

Pull request was converted to draft

@mberr mberr marked this pull request as ready for review September 23, 2023 13:32
@mberr mberr merged commit a541a3b into master Sep 23, 2023
9 checks passed
@mberr mberr deleted the fix-metric-resolution branch September 23, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants