Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #124

Merged
merged 1 commit into from Nov 2, 2020
Merged

Update documentation #124

merged 1 commit into from Nov 2, 2020

Conversation

lvermue
Copy link
Member

@lvermue lvermue commented Nov 2, 2020

While going through the code for #123 I found some spots in the documentation that are not updated to the correct function argument names.

@lvermue lvermue requested a review from cthoyt November 2, 2020 10:08
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very perceptive

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   67.17%   67.17%           
=======================================
  Files          91       91           
  Lines        5783     5783           
  Branches      741      741           
=======================================
  Hits         3885     3885           
  Misses       1691     1691           
  Partials      207      207           
Impacted Files Coverage Δ
src/pykeen/hpo/__init__.py 100.00% <ø> (ø)
src/pykeen/stoppers/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a5186...ff61516. Read the comment docs.

@lvermue lvermue merged commit dc247da into master Nov 2, 2020
@lvermue lvermue deleted the update_documentation branch November 2, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants