Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ€”πŸ™…β€β™€οΈ Fix TransH HPO compatability #1277

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

mberr
Copy link
Member

@mberr mberr commented Jun 2, 2023

This PR renames TransH's entity_regularizer to regularizer which is less expressive, but makes TransH work with the HPO code again.

Fix #1273

@mberr mberr changed the title Fix TransH HPO compatability πŸ€”πŸ™…β€β™€οΈ Fix TransH HPO compatability Jun 2, 2023
@mberr mberr marked this pull request as ready for review June 2, 2023 09:31
@mberr mberr marked this pull request as draft June 2, 2023 09:45
@mberr mberr marked this pull request as ready for review June 2, 2023 09:45
@mberr mberr merged commit d1222b7 into master Aug 3, 2023
9 checks passed
@mberr mberr deleted the fix-transh-hpo-compatability branch August 3, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPO with TransH not working
1 participant