Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☑️💸 Update Losses' HPO default range checks #1337

Merged
merged 10 commits into from
Oct 7, 2023
Merged

☑️💸 Update Losses' HPO default range checks #1337

merged 10 commits into from
Oct 7, 2023

Conversation

mberr
Copy link
Member

@mberr mberr commented Oct 5, 2023 •
edited
Loading

  • check instantiation of losses for a few configurations derived from the hpo_default
  • fix an issue with the default values of DoubleMarginLoss (bb88719)
  • add suitable hpo_defaults to the general
    • MarginPairwiseLoss
    • DeltaPointwiseLoss

Fix #1334

@mberr mberr changed the title Update Losses' HPO default range checks ☑️💸 Update Losses' HPO default range checks Oct 6, 2023
@mberr mberr marked this pull request as ready for review October 6, 2023 21:43
@mberr mberr requested a review from cthoyt October 6, 2023 21:57
@mberr mberr marked this pull request as draft October 7, 2023 09:10
@mberr mberr marked this pull request as ready for review October 7, 2023 09:24
cthoyt
cthoyt reviewed Oct 7, 2023
View reviewed changes
tests/cases.py Show resolved Hide resolved
@cthoyt
Copy link
Member

cthoyt commented Oct 7, 2023

thanks @mberr !

@mberr mberr enabled auto-merge (squash) October 7, 2023 11:02
@mberr mberr merged commit c94213c into master Oct 7, 2023
11 checks passed
@mberr mberr deleted the improve-loss-hpo-default-checking branch October 7, 2023 11:26
@mberr mberr mentioned this pull request Oct 8, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt cthoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mberr @cthoyt