Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鉁煏碉笍 Fix mypy #1387

Merged
merged 6 commits into from
May 4, 2024
Merged

鉁煏碉笍 Fix mypy #1387

merged 6 commits into from
May 4, 2024

Conversation

mberr
Copy link
Member

@mberr mberr commented May 4, 2024

  • Fix an issue which came up after using the most recent mypy version
  • Re-use OneOrSequence type annotation consistently in this method
  • Re-use upgrade_to_sequence utility
  • get rid of custom PyTorch Geometric installation for tests - this should also fix the issue with CI breaking after each torch release; citing from the README

From PyG 2.3 onwards, you can install and use PyG without any external library required except for PyTorch. For this, simply run

pip install torch_geometric

Additional Libraries

If you want to utilize the full set of features from PyG, there exists several additional libraries you may want to install: [...]

@mberr mberr marked this pull request as ready for review May 4, 2024 16:12
@mberr mberr changed the title Fix mypy 鉁煏碉笍 Fix mypy May 4, 2024
@mberr mberr enabled auto-merge (squash) May 4, 2024 16:33
@mberr mberr merged commit ac85bef into master May 4, 2024
10 checks passed
@mberr mberr deleted the fix-mypy branch May 4, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant