New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows testing to GitHub Actions #194
Conversation
@lvermue it looks like the windows configuration works. You can check it out in its own workflow, but I guess this needs to be copied twice into |
Trigger CI
@lvermue also it's quite slow. I wonder if there's any caching we can do to make these anaconda builds faster |
python-version: [ 3.7, 3.8 ] | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: conda-incubator/setup-miniconda@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthoyt Is there a reason you install a new conda instance and aren't using the default one that comes with the Github Actions virtual environment pre-installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/conda-incubator/setup-miniconda#conda-incubatorsetup-miniconda Apparently they try to locate the pre-installed ones. So this shouldn't be the reason for the slowness 🤷♂️
As written here #194 (comment), the Github Action virtual environments come with Conda pre-installed. The only way to have everything pre-installed would be to have our own instances, so maybe in the future 😅 |
@PyKEEN-bot Can you attest this code? |
@PyKEEN-bot Once more. Can you attest this code? |
Closes #166