Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows testing to GitHub Actions #194

Merged
merged 16 commits into from Dec 4, 2020
Merged

Add windows testing to GitHub Actions #194

merged 16 commits into from Dec 4, 2020

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Dec 4, 2020

Closes #166

@cthoyt cthoyt added the meta project-level stuff label Dec 4, 2020
@cthoyt
Copy link
Member Author

cthoyt commented Dec 4, 2020

@lvermue it looks like the windows configuration works. You can check it out in its own workflow, but I guess this needs to be copied twice into tests.yml and tests_master.yml, right?

@cthoyt cthoyt marked this pull request as ready for review December 4, 2020 17:51
@cthoyt
Copy link
Member Author

cthoyt commented Dec 4, 2020

@lvermue also it's quite slow. I wonder if there's any caching we can do to make these anaconda builds faster

python-version: [ 3.7, 3.8 ]
steps:
- uses: actions/checkout@v2
- uses: conda-incubator/setup-miniconda@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthoyt Is there a reason you install a new conda instance and aren't using the default one that comes with the Github Actions virtual environment pre-installed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/conda-incubator/setup-miniconda#conda-incubatorsetup-miniconda Apparently they try to locate the pre-installed ones. So this shouldn't be the reason for the slowness 🤷‍♂️

@lvermue
Copy link
Member

lvermue commented Dec 4, 2020

@lvermue also it's quite slow. I wonder if there's any caching we can do to make these anaconda builds faster

As written here #194 (comment), the Github Action virtual environments come with Conda pre-installed. The only way to have everything pre-installed would be to have our own instances, so maybe in the future 😅

@lvermue
Copy link
Member

lvermue commented Dec 4, 2020

@PyKEEN-bot Can you attest this code?

@lvermue
Copy link
Member

lvermue commented Dec 4, 2020

@PyKEEN-bot Once more. Can you attest this code?

@lvermue lvermue merged commit d4c1fec into master Dec 4, 2020
@lvermue lvermue deleted the gh-actions-windows branch December 4, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta project-level stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from AppVeyor to GitHub Actions
3 participants