Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade sampler capability #209
Upgrade sampler capability #209
Changes from all commits
10b62d9
6b48579
5d47a41
f3ff3cf
d7e108a
ade1143
396f27d
1f006ed
6695397
dee3fa4
39ae601
07b784c
b591ba9
5e8c020
b7f9fe1
a0d3e4f
2c5b717
20f333d
cb47432
7af702d
d3852cd
e346db8
bf50831
97a76fc
9ec8b14
8087c53
d687519
94e6140
593a786
d28ad30
a5825ac
a0766fe
c8ca629
8500c83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the reviewer have a specific use case when you might want to do something other than default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but there could be reasonable situations, e.g. when working with images where you know the objects/entities, but are interested in training to reason the most likely relation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find a reference right now, but iirc visual relation detection usually first detects all objects in the image (
h
/t
) and then predicts the relations between them (r
). One argument is that the distribution of visual representations of relations is more of a long tail distribution, and might include representations of the objects: e.g. in(man, rides, bike)
' the visual representations ofrides
likely (partially) shows both, the man and the bike.Far better explanations can be given by @sharifza 🙂