Add generalized metadata storage to TriplesFactory and improve repr #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PyKEEN-bot test |
|
@cthoyt What about directly extending it to store a dictionary of metadata in the triples factory? We could also update |
|
@mberr good point, this was the solution in the other one too |
cthoyt
changed the title
|
@PyKEEN-bot test plz |
mberr
reviewed
Dec 11, 2020
Trigger CI
Trigger CI
mberr
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142, Deprecates #144, Deprecates #145
Since #193, triples factories don't need paths. However, they're useful to have around, so this PR is a re-write of #145 such that they can be passed around in a metadata dictionary, along with any other information.