Extend normalization to other p norms #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Dec 21, 2020
cthoyt
reviewed
Dec 21, 2020
cthoyt
reviewed
Dec 21, 2020
|
@PyKEEN-bot would you mind to test this? |
… into update-lp-regularizer-normalize
|
@PyKEEN-bot please test one more time |
mali-git
approved these changes
Dec 21, 2020
|
Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When choosing
normalize=TrueforLpRegularizer, the term is normalized by the expected norm value to isolate the regularization weight effects from the embedding dimension. Before, onlyp=1andp=2were supported. This PR extends this to anyp != inf.