馃Ж 馃懛 Add interaction modules #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #240
cthoyt
commented
Jan 21, 2021
All the tests still pass, gucci
Co-Authored-By: Max Berrendorf <berrendorf@dbs.ifi.lmu.de>
This will come back in the next PR
Trigger CI
Trigger CI
mberr
reviewed
Jan 22, 2021
Trigger CI
mberr
approved these changes
Jan 22, 2021
Yevgnen
reviewed
Dec 13, 2021
|
|
||
|
|
||
| def _get_batches(z, slice_size): | ||
| for batch in zip(*(hh.split(slice_size, dim=1) for hh in ensure_tuple(z)[0])): |
There was a problem hiding this comment.
Hi, I'm trying to learn the code. Why dim=1 is fixed here? I've thought dim should be passed from _forward_slicing_wrapper for different h, r, t.
There was a problem hiding this comment.
Hi @Yevgnen ,
thanks for looking in such old PRs. This seems to be an error indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240
This PR adds the PyTorch module wrappers around each of the functional forms of the interaction functions proposed in the previous PR (#238) as well as tests, requisite utility functions, and documentation.
This PR doesn't bring over the literal modules, that's pushed until #244