馃尰 鉂勶笍 Add dtype annotation to pykeen.nn.Embedding #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger CI
Trigger CI
cthoyt
changed the title
cthoyt
commented
Feb 12, 2021
Merged
|
Could use some tests... |
|
@PyKEEN-bot test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the next step after #287 in bringing the embeddings and embedding specifications into the future. It adds the ability to annotate the data inside the embedding. Unfortunately, embeddings do not yet support native complex tensors (see #134) so this is a nice abstraction in the mean time. Futher, it is the final abstraction on the embeddings/representations necessary for #260. Luckily, very little code needed to be changed.
All credit goes to @mberr since this code was originally in #107 and later #260.
Tasks: