♻️ 👌 Update interaction function resolution for new style models

[mberr]

follow-up of #384

[mberr]

We could also directly put this as default value into the __init__ method's signature:

def __init__(
  self,
  ...,
  interaction_kwargs=frozendict(p=p, power_norm=power_norm),
  ...,
)

[cthoyt]

Not exactly sure if this is the same as 859db48. Why is frozendict necessary?

[cthoyt]

Nevermind the last comment. I don't think you can actually do what you are suggesting since we're passing p and power_norm in the init itself

[mberr]

Yes, I was thinking about replacing it.

Before

 def __init__(
        ...,
        p: int = 2,
        power_norm: bool = True,
        ...,
    ) -> None:

After

 def __init__(
        ...,
        interaction_kwargs=frozendict(p=2, power_norm=True),
        ...,
    ) -> None:

The second option makes it directly clear where the parameter go to.

[cthoyt]

Disagree. The point of the high level model class is to abstract away knowing where these parameters go or how they're handled. It should be completely flat not only for users, but also since this is how the HPO and CLI builders work

[cthoyt]

@PyKEEN-bot test plz