Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💠 💠 Update ConvKB to ERModel #425

Merged
merged 9 commits into from
Nov 8, 2021
Merged

💠 💠 Update ConvKB to ERModel #425

merged 9 commits into from
Nov 8, 2021

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented May 6, 2021 •
edited

Closes #424 by upgrading ConvKB to use the ERModel.

@cthoyt cthoyt mentioned this pull request May 6, 2021
Merged
@cthoyt cthoyt changed the title 💠 💠 Convert some old-style models to new-style models 💠 💠 Update ConvKB to ERModel Jun 2, 2021
@cthoyt cthoyt added enhancement New feature or request 💃 Model Related to interaction models or interaction functions labels Jun 2, 2021
@cthoyt cthoyt marked this pull request as ready for review November 5, 2021 21:45
@cthoyt cthoyt requested a review from mberr November 5, 2021 21:48
@cthoyt
Copy link
Member Author

cthoyt commented Nov 8, 2021

@PyKEEN-bot test

@cthoyt cthoyt merged commit e21e8df into master Nov 8, 2021
@cthoyt cthoyt deleted the futurize-models branch November 8, 2021 20:35
@mberr mberr added the ✨ ERModel Upgrading old-style models to new-style label Apr 16, 2022
@mberr mberr added this to Done in ERModel Migration May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberr mberr mberr left review comments

Assignees
No one assigned
Labels
enhancement New feature or request ✨ ERModel Upgrading old-style models to new-style 💃 Model Related to interaction models or interaction functions
Projects
No open projects
ERModel Migration
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port ConvKB to ERModel
3 participants
@cthoyt @mberr @PyKEEN-bot