Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃啎馃惇 Add YAML experiment format #612

Merged
merged 21 commits into from
Oct 25, 2021
Merged

馃啎馃惇 Add YAML experiment format #612

merged 21 commits into from
Oct 25, 2021

Conversation

mberr
Copy link
Member

@mberr mberr commented Oct 25, 2021 •
edited

In contrast to JSON, YAML allows comments. These are particularly valuable for documentation of hyper-parameter choices, e.g., if not all of them were present in the publication, or code and publication disagree.

Closes #611

cthoyt
cthoyt reviewed Oct 25, 2021
View reviewed changes
src/pykeen/pipeline/api.py Outdated Show resolved Hide resolved
@mberr mberr requested a review from cthoyt October 25, 2021 12:06
cthoyt
cthoyt reviewed Oct 25, 2021
View reviewed changes
src/pykeen/pipeline/api.py Outdated Show resolved Hide resolved
@mberr mberr requested a review from cthoyt October 25, 2021 12:45
@mberr
Copy link
Member Author

mberr commented Oct 25, 2021

@cthoyt I reverted most of the JSON to YAML conversions to reduce the diff. I chose RGCN since this configuration will be updated in #610 anyway.

@mberr
Copy link
Member Author

mberr commented Oct 25, 2021

@cthoyt merge if satisfied

@mberr mberr requested a review from cthoyt October 25, 2021 16:35
@cthoyt
Update setup.cfg
f679a02 
Trigger CI
cthoyt
cthoyt approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added pyyaml as a requirement in setup.cfg. Please add some emoji before merging!

@mberr mberr changed the title Change experiment format from JSON to YAML Add YAML experiment format Oct 25, 2021
@mberr mberr changed the title Add YAML experiment format 馃啎馃惇 Add YAML experiment format Oct 25, 2021
@mberr mberr merged commit 049ab51 into master Oct 25, 2021
@mberr mberr deleted the yaml-experiment-configurations branch October 25, 2021 17:40
@mberr mberr mentioned this pull request Nov 4, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt cthoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change file format of experiment configurations
2 participants
@mberr @cthoyt