Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摝馃摎 Update BoxE reproducibility configurations #631

Merged
merged 33 commits into from
Apr 28, 2022
Merged

馃摝馃摎 Update BoxE reproducibility configurations #631

merged 33 commits into from
Apr 28, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented Nov 11, 2021 •
edited

This PR adjusts a few settings in the reproducibility configurations.

In particular, it

  • ensures that the model corresponding to the best MRR evaluated every 100 epochs is used.
  • fixes the indention of the filtered argument for the rank-based evaluator
  • adds H@{1,3} results

Confirmed results:

@mberr
Copy link
Member Author

mberr commented Nov 17, 2021

The WN18RR configuration can obtain the results.

@cthoyt
Copy link
Member

cthoyt commented Dec 16, 2021

Ongoing experiment discussion https://lmudbs.slack.com/archives/GKNTFMW2D/p1639677356008500

@mberr mberr marked this pull request as ready for review April 19, 2022 09:53
@mberr mberr marked this pull request as draft April 19, 2022 09:53
@mberr
Copy link
Member Author

mberr commented Apr 28, 2022

@PyKEEN-bot test

@mberr mberr marked this pull request as ready for review April 28, 2022 10:36
@mberr
Copy link
Member Author

mberr commented Apr 28, 2022

@PyKEEN-bot test

@mberr
Copy link
Member Author

mberr commented Apr 28, 2022

@PyKEEN-bot test

@mberr mberr requested a review from cthoyt April 28, 2022 11:56
@mberr mberr changed the title Update BoxE reproducibility configurations 馃摝馃摎 Update BoxE reproducibility configurations Apr 28, 2022
@mberr mberr enabled auto-merge (squash) April 28, 2022 18:17
@mberr
Copy link
Member Author

mberr commented Apr 28, 2022

@PyKEEN-bot test

@mberr mberr merged commit 1394434 into master Apr 28, 2022
@mberr mberr deleted the fix-boxe-config branch April 28, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt Awaiting requested review from cthoyt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mberr @cthoyt @PyKEEN-bot