🐍 🛤️ Python result tracker #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigger ci
trigger ci
trigger ci
cthoyt
reviewed
Dec 12, 2021
trigger ci
Trigger CI @mberr be careful on the placing of the spaces with code blocks - you can always try building the docs locally to check that they render properly
trigger ci
cthoyt
reviewed
Dec 12, 2021
| @@ -50,8 +50,7 @@ def end_run(self, success: bool = True) -> None: | |||
|
|
|||
|
|
|||
| class PythonResultTracker(ResultTracker): | |||
| """ | |||
| A tracker which stores everything in Python dictionaries. | |||
| """A tracker which stores everything in Python dictionaries. | |||
There was a problem hiding this comment.
pykeen readme does not like empty first lines 😕
There was a problem hiding this comment.
Haha this is obviously my doing. We could add a string strip in there so you can continue to write docstrings this way
cthoyt
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple in-memory result tracker, which stores parameters and metrics in Python dictionaries.