-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃 鉁堬笍 Make mock model importable #691
Conversation
@PyKEEN-bot test |
The remaining issues in the tests when applied to this parameter-less model is that it doesn't have any trainable parameters. I think this might be a silly rabbit hole to spend time on, so it might be better just to not use the typical model testing framework on it. |
Trigger CI
Trigger CI
Trigger CI
Trigger CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the comment, lgtm
This PR moves the mock model from the tests into the main package. This model is useful for baseline comparison