Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃惣 馃様 Switch np.loadtxt to pandas.read_csv #695

Merged
merged 5 commits into from
Dec 21, 2021
Merged

Conversation

mberr
Copy link
Member

@mberr mberr commented Dec 21, 2021

fixes #694

@cthoyt
Copy link
Member

cthoyt commented Dec 21, 2021

There might be advantages to including the column_remapping argument via the usecols argument in pandas.read_csv() since I think it's more memory-efficient (changed in 9186d5d)

src/pykeen/triples/utils.py Outdated Show resolved Hide resolved
@cthoyt
Copy link
Member

cthoyt commented Dec 21, 2021

@PyKEEN-bot test

@cthoyt cthoyt changed the title Switch np.loadtxt to pandas.read_csv 馃惣 馃様 Switch np.loadtxt to pandas.read_csv Dec 21, 2021
@cthoyt cthoyt merged commit e401e96 into master Dec 21, 2021
@cthoyt cthoyt deleted the fix-load-triples branch December 21, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_triples and np.loadtxt might load incorrect data
3 participants