Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛵💻 Make sure indices are moved to device #800

Merged
merged 8 commits into from
Feb 21, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented Feb 21, 2022

This PR modifies representation modules to move the provided indices to the correct device.

Fix #794

@mberr mberr changed the title Make sure indices are moved to device ⛵💻 Make sure indices are moved to device Feb 21, 2022
@mberr mberr requested a review from migalkin February 21, 2022 09:48
@cthoyt
Copy link
Member

cthoyt commented Feb 21, 2022

Everything looks pretty good, but I had a few questions/suggestions

@mberr
Copy link
Member Author

mberr commented Feb 21, 2022

@PyKEEN-bot test

@mberr mberr enabled auto-merge (squash) February 21, 2022 12:51
@mberr mberr merged commit f6cbd3f into master Feb 21, 2022
@mberr mberr deleted the fix-indices-on-wrong-device branch February 21, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubsetRepresentationModule default indices are always on CPU
3 participants