Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敘 馃悗 Update value range & docstring of adjusted metrics #823

Merged
merged 14 commits into from
Mar 9, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented Mar 9, 2022

This PR updates the value ranges of adjusted metrics with guaranteed lower bounds, as well as their docstring with the analytical form of the lower bound. It also fixes displaying infinite lower bounds.

@mberr mberr requested a review from cthoyt March 9, 2022 13:59
@mberr mberr changed the title Update docstring of adjusted metrics Update value range & docstring of adjusted metrics Mar 9, 2022
trigger ci
trigger ci
@mberr mberr changed the title Update value range & docstring of adjusted metrics 馃敘馃悗 Update value range & docstring of adjusted metrics Mar 9, 2022
@cthoyt cthoyt changed the title 馃敘馃悗 Update value range & docstring of adjusted metrics 馃敘 馃悗 Update value range & docstring of adjusted metrics Mar 9, 2022
@cthoyt
Copy link
Member

cthoyt commented Mar 9, 2022

@mberr looks like there are some numerical issues with the new bounds of adjusted hits at K

@mberr
Copy link
Member Author

mberr commented Mar 9, 2022

@mberr looks like there are some numerical issues with the new bounds of adjusted hits at K

-3.4158865620691894 is pretty far of -1 thb 馃槄

EDIT: I think this is because AdjustedHitsAtK is actually the index, (H@k - E[H@k]) / (1 - E[H@k]) with minimum value -E[H@k]/(1 - E[H@k]). With E[H@k] -> 1, this approaches -inf (cf. here).

src/pykeen/metrics/ranking.py Outdated Show resolved Hide resolved
src/pykeen/metrics/ranking.py Outdated Show resolved Hide resolved
src/pykeen/metrics/ranking.py Outdated Show resolved Hide resolved
src/pykeen/metrics/ranking.py Outdated Show resolved Hide resolved
cthoyt and others added 6 commits March 9, 2022 21:01
Co-authored-by: Max Berrendorf <berrendorf@dbs.ifi.lmu.de>
Co-authored-by: Max Berrendorf <berrendorf@dbs.ifi.lmu.de>
Co-authored-by: Max Berrendorf <berrendorf@dbs.ifi.lmu.de>
Trigger CI
Trigger CI
@cthoyt
Copy link
Member

cthoyt commented Mar 9, 2022

@PyKEEN-bot test

@cthoyt cthoyt enabled auto-merge (squash) March 9, 2022 22:19
@cthoyt cthoyt merged commit f04bd4f into master Mar 9, 2022
@cthoyt cthoyt deleted the update-metrics branch March 9, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants