🪡🗜️ Refactor derived metrics #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigger ci
trigger ci
|
I think it's about time we wrote a few unit tests for these |
|
@cthoyt ready from my side |
cthoyt
reviewed
Mar 14, 2022
|
@cthoyt locally, the test for variance of |
cthoyt
reviewed
Mar 14, 2022
|
@PyKEEN-bot test |
|
@PyKEEN-bot test |
trigger ci
Trigger CI
cthoyt
approved these changes
Mar 22, 2022
Trigger CI
Trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the z-adjustment's super calls to not use the expected value / std of the z-mixin (which is always 0/1), but rather of the mixed metric.
It goes even further to refactor the various adjusted metrics to use composition instead of inheritance, and adds even more closed-form calculation of their respective expectations and variances.