-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌀🔗 Extend EA datasets to allow loading a unified graph #871
Conversation
@dobraczka - any thoughts on this? maybe also regarding extension to the OpenEA dataset family, or generally adding a workflow to perform EA as LP task? |
I can take a detailled look at it next week since I have vacation right now. I think treating EA as a special LP task can only get you so far. and know that A == D you add the triples The other simple strategy is "sharing" where same entites get the same id, but the TriplesFactory does not like that. I am currently working on inductive EA. I already created semi- and fully-inductive datasets from the OpenEA datasets and now I'm trying to get a sensible baseline using NodePiece. I got some results already, but it needs a bit of work still. If you or @migalkin are interested in collaborating on the inductive EA stuff let me know. |
Thanks @dobraczka for the quick response despite being on vacation 😅 If you send me your preferred email to max.berrendorf@gmail.com, I'll send you an invite to our PyKEEN Slack. |
I like that you already included the possibility to extend this with different combination strategies, which is what I was thinking about, but that can be done in a seperate PR. |
# store for repr | ||
self.side = side | ||
# split | ||
training, testing, validation = tf.split(ratios=split_ratios, random_state=random_state) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This train/test/val split would generally only make sense for a LP setting, right? In the EA setting we would want to split the alignment tuples appropriately.
But creating EA-specific settings could also be done in a seperate PR.
I removed some of the additional changes to reduce this PR to a atomic change. The old version is available here. |
trigger ci
trigger ci
trigger ci
@PyKEEN-bot test |
This PR adds support for loading KGs from entity alignment datasets as a joint graph comprising both individual sides.