Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
DistMult
toERModel
.Benchmark
TL;DR: Overall comparable runtime; in training slightly slower; in some evaluation settings faster.
pykeen experiments reproduce distmult yang2014 fb15k
master
)update-distmult-to-ermodel
)*
:sub_batch_size=24155
**
:batch_size=2048.
pykeen experiments reproduce distmult yang2014 wn18
master
)update-distmult-to-ermodel
)*
:sub_batch_size=24155
**
:batch_size=1024.
pykeen train distmult --embedding-dim 128 --training-loop lcwa --create-inverse-triples --dataset fb15k237 --batch-size 1024
master
)update-distmult-to-ermodel
)*
:batch_size=2048