Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨🤖 Update DistMult to ERModel #874

Merged
merged 5 commits into from
Apr 17, 2022
Merged

Conversation

mberr
Copy link
Member

@mberr mberr commented Apr 16, 2022

This PR updates DistMult to ERModel.

Benchmark

TL;DR: Overall comparable runtime; in training slightly slower; in some evaluation settings faster.

Key Value
OS posix
Platform Linux
Release 5.4.0-81-generic
Time Sat Apr 16 18:12:51 2022
Python 3.8.10
PyKEEN 1.8.1-dev
PyKEEN Hash *
PyKEEN Branch *
PyTorch 1.10.0+cu113
CUDA Available? true
CUDA Version 11.3
cuDNN Version 8200
pykeen experiments reproduce distmult yang2014 fb15k
commit train eval
661b0eb (master) 3.04s* 12.90s**
a7bc64e (update-distmult-to-ermodel) 3.10s* 11.63s**
  • *: sub_batch_size=24155
  • **: batch_size=2048.
pykeen experiments reproduce distmult yang2014 wn18
commit train eval
661b0eb (master) 1.03s* 2.12s**
a7bc64e (update-distmult-to-ermodel) 1.04s* 1.43s**
  • *: sub_batch_size=24155
  • **: batch_size=1024.
pykeen train distmult --embedding-dim 128 --training-loop lcwa --create-inverse-triples --dataset fb15k237 --batch-size 1024
commit train eval
661b0eb (master) 51.87s 3.27s*
a7bc64e (update-distmult-to-ermodel) 51.90s 3.29s*
  • *: batch_size=2048

@mberr mberr marked this pull request as ready for review April 16, 2022 15:17
@mberr
Copy link
Member Author

mberr commented Apr 16, 2022

@PyKEEN-bot test

@mberr mberr added the ✨ ERModel Upgrading old-style models to new-style label Apr 16, 2022
@mberr mberr mentioned this pull request Apr 16, 2022
8 tasks
@mberr mberr requested a review from cthoyt April 16, 2022 19:56
@cthoyt cthoyt merged commit 89cfec9 into master Apr 17, 2022
@cthoyt cthoyt deleted the update-distmult-to-ermodel branch April 17, 2022 06:24
@mberr mberr added this to Done in ERModel Migration May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ ERModel Upgrading old-style models to new-style
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants