Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖥️🦎 Fix complex initialization #888

Merged
merged 11 commits into from
Apr 28, 2022
Merged

Conversation

mberr
Copy link
Member

@mberr mberr commented Apr 26, 2022

This PR fixes initialization of complex tensors.

Fix #885

@mberr mberr changed the title Fix complex initialization 🖥️🦎 Fix complex initialization Apr 26, 2022
@mberr mberr requested a review from cthoyt April 26, 2022 11:23
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the math but i'm confident in our testing suite :)

@mberr
Copy link
Member Author

mberr commented Apr 26, 2022

I'm not super familiar with the math but i'm confident in our testing suite :)

It is essentially the same as https://pytorch.org/docs/stable/_modules/torch/nn/init.html#xavier_uniform_, but we set fan_in to zero.

@mberr mberr merged commit 5c6b939 into master Apr 28, 2022
@mberr mberr deleted the fix-complex-initialization branch April 28, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Understanding differences in RotatE performance between version 1.7.0 and 1.8.1
2 participants