🪛📁 Fix directory path normalization #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigger ci
trigger ci
trigger ci
trigger ci
mberr
changed the title
cthoyt
reviewed
Apr 30, 2022
src/pykeen/datasets/base.py
Outdated
| def _cache_sub_directories(self) -> Iterable[str]: | ||
| """Iterate over appropriate cache sub-directory.""" | ||
| # TODO: use class-resolver normalize? | ||
| return self.__class__.__name__.lower() |
There was a problem hiding this comment.
this looks like a bug, this returns the string instead of yields it. why does this need to be a function? it's only used once
There was a problem hiding this comment.
it is overridden by wk3l to share the cache between cn3l, wk3l15k and wk3l120k
|
cf. 78e2cff for fix to failing pipeline |
|
@PyKEEN-bot test |
trigger ci
triggerci
cthoyt
approved these changes
May 2, 2022
|
@PyKEEN-bot test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #887