-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📔✅ Update Docstring Coverage check #892
Conversation
trigger ci
the only remaining error should be fixed by #893 |
super().__init__(p=p, power_norm=power_norm) | ||
|
||
# docstr-coverage: inherited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this here twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -964,6 +1040,7 @@ class SEInteraction( | |||
func = pkf.se_interaction | |||
|
|||
@staticmethod | |||
# docstr-coverage: inherited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably an artifact from the automated script, right? it's weird this is after the decorator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super().__init__(p=p, power_norm=power_norm) | ||
|
||
@staticmethod | ||
# docstr-coverage: inherited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super().__init__(p=p, power_norm=power_norm) | ||
|
||
@staticmethod | ||
# docstr-coverage: inherited |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates the coverage check to check all files by default. It also adds explicit ignores where appropriate, and missing docstring otherwise.
I used a (hacky) script to add some
# docstr-coverage: inherited
in deae930, which I add here for reference.