Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📐📨 PyTorch Geometric Message Passing Representations #894

Merged
merged 65 commits into from
May 2, 2022
Merged

Conversation

mberr
Copy link
Member

@mberr mberr commented Apr 28, 2022

Related to #620, this PR adds a general structure to build representations with message passing layers from PyG.

@mberr mberr marked this pull request as ready for review April 28, 2022 20:42
@mberr
Copy link
Member Author

mberr commented Apr 28, 2022

I have not tested training models with it since I broke by PyG environment, and now get seg-faults for both CPU and GPU 😅

@mberr mberr requested a review from cthoyt April 28, 2022 20:45
tox.ini Outdated Show resolved Hide resolved
@cthoyt
Copy link
Member

cthoyt commented Apr 29, 2022

Needs high level documentation on what this enables

PyG *must* be installed *after* torch has been installed
src/pykeen/nn/pyg.py Outdated Show resolved Hide resolved
@mberr mberr changed the title PyTorch Geometric Message Passing Representations 📐📨 PyTorch Geometric Message Passing Representations Apr 30, 2022
src/pykeen/nn/__init__.py Outdated Show resolved Hide resolved
@cthoyt
Copy link
Member

cthoyt commented May 2, 2022

@PyKEEN-bot test

@cthoyt cthoyt enabled auto-merge (squash) May 2, 2022 10:23
@cthoyt cthoyt merged commit 4dcfd46 into master May 2, 2022
@cthoyt cthoyt deleted the pyg2 branch May 2, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants