馃幒馃幏 Fix wk3l loading #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
May 4, 2022
trigger ci
trigger ci
cthoyt
reviewed
May 4, 2022
| @@ -102,6 +102,7 @@ def _load_df(self, key: Union[None, EASide, Tuple[EASide, EASide]], **kwargs) -> | |||
| engine="python", | |||
| encoding="utf8", | |||
| dtype=str, | |||
| keep_default_na=False, | |||
There was a problem hiding this comment.
so this was sufficient? because this won't solve the issue if there are empty entries
There was a problem hiding this comment.
empty entries are read as nan.
There was a problem hiding this comment.
so even if there's an empty string it gets the string "nan"?
maybe you should still do dropna() in addition to keep_default_na=False,
|
@PyKEEN-bot test |
|
Merge if it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #906
Also fixed an unrelated error in mapping the alignment to IDs.