Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎲🚶 Random Walk Positional Encoding #918

Merged
merged 41 commits into from
May 12, 2022
Merged

🎲🚶 Random Walk Positional Encoding #918

merged 41 commits into from
May 12, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented May 10, 2022

Implements random walk positional encoding from https://arxiv.org/abs/2110.07875

For benchmarking different options of extracting diagonal entries of sparse matrices, cf.
https://github.com/pykeen/benchmark-sparse-diagonal

src/pykeen/nn/init.py Outdated Show resolved Hide resolved
src/pykeen/nn/init.py Outdated Show resolved Hide resolved
trigger ci
@mberr mberr marked this pull request as ready for review May 10, 2022 15:59
@mberr mberr changed the title Random Walk Positional Encoding 🎲🚶 Random Walk Positional Encoding May 10, 2022
src/pykeen/nn/init.py Outdated Show resolved Hide resolved
mberr and others added 3 commits May 11, 2022 11:39
mberr added a commit to pykeen/benchmark-sparse-diagonal that referenced this pull request May 11, 2022
@mberr
Copy link
Member Author

mberr commented May 11, 2022

relevant issue from PyTorch: pytorch/pytorch#24937 - it looks like sparse index select may come soon(-ish); maybe with 1.12

@migalkin
Copy link
Member

maybe with 1.12

the PR was merged almost 3 years ago and is still not in the release? 👀

@mberr
Copy link
Member Author

mberr commented May 11, 2022

maybe with 1.12

the PR was merged almost 3 years ago and is still not in the release? eyes

nvm, this seems to be index_select, which is only for one-dimensional selection.

src/pykeen/nn/utils.py Outdated Show resolved Hide resolved
@cthoyt
Copy link
Member

cthoyt commented May 12, 2022

@PyKEEN-bot test

@mberr mberr enabled auto-merge (squash) May 12, 2022 15:46
@mberr
Copy link
Member Author

mberr commented May 12, 2022

@PyKEEN-bot test

@mberr mberr merged commit cd1cdf1 into master May 12, 2022
@mberr mberr deleted the rwpe branch May 12, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants