Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鈩癸笍馃殌 Update InfoNCE LCWA implementation #928

Merged
merged 13 commits into from
May 17, 2022
Merged

Conversation

mberr
Copy link
Member

@mberr mberr commented May 16, 2022

As a follow-up to #926, this PR updates the InfoNCE loss' LCWA processing to a fixed memory complexity implementation.

@mberr mberr changed the title Update InfoNCE LCWA implementation 鈩癸笍馃殌 Update InfoNCE LCWA implementation May 16, 2022
@mberr mberr requested a review from migalkin May 16, 2022 18:20
src/pykeen/losses.py Outdated Show resolved Hide resolved
trigger ci
@cthoyt
Copy link
Member

cthoyt commented May 16, 2022

i love the deeply nested class structure - it's a very cool demonstration of how they are all related

@mberr mberr merged commit d7ee986 into master May 17, 2022
@mberr mberr deleted the update-info-nce-lcwa branch May 17, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants