Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毃馃搳 Cast kwargs as strings in plot_er #945

Merged
merged 10 commits into from
May 28, 2022
Merged

Conversation

vsocrates
Copy link
Contributor

@vsocrates vsocrates commented May 27, 2022

Closes #944

Description of the Change

  • Cast all keyword argument values to strings in plot_er
  • Enable passing a custom subtitle

Possible Drawbacks

May present some problems if the passed kwarg is a function or something that won't neatly be represented in the title as a string, maybe allow the user to pass in a custom title?

Verification Process

Release Notes

  • Fixed crashes in plot_er when reducer kwargs aren't strings

Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Might be more simple to use an f-string instead of the inner string join at this point

@cthoyt
Copy link
Member

cthoyt commented May 27, 2022

The pr title needs emoji in it too :)

@vsocrates
Copy link
Contributor Author

Sounds good! Will update later tonight!

@cthoyt
Copy link
Member

cthoyt commented May 28, 2022

@PyKEEN-bot test

@cthoyt cthoyt changed the title Cast kwargs as strings in plot_er 馃毃馃搳 Cast kwargs as strings in plot_er May 28, 2022
@cthoyt
Copy link
Member

cthoyt commented May 28, 2022

@PyKEEN-bot test

@cthoyt cthoyt merged commit 9acdfeb into pykeen:master May 28, 2022
@cthoyt
Copy link
Member

cthoyt commented May 28, 2022

@vsocrates thanks for the update! I'd suggest future PRs you make branches off of the main branch on your fork so previous commits don't get mixed in. We use the squash+merge contribution model to keep our commit histories focused on high-level narrative

@vsocrates
Copy link
Contributor Author

Will do, thanks for the f-string fix too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_er reducer arguments crash plots on non-string values
4 participants