-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃毃馃搳 Cast kwargs as strings in plot_er #945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Might be more simple to use an f-string instead of the inner string join at this point
The pr title needs emoji in it too :) |
Sounds good! Will update later tonight! |
@PyKEEN-bot test |
@PyKEEN-bot test |
@vsocrates thanks for the update! I'd suggest future PRs you make branches off of the main branch on your fork so previous commits don't get mixed in. We use the squash+merge contribution model to keep our commit histories focused on high-level narrative |
Will do, thanks for the f-string fix too! |
Closes #944
Description of the Change
plot_er
Possible Drawbacks
May present some problems if the passed kwarg is a function or something that won't neatly be represented in the title as a string, maybe allow the user to pass in a custom title?
Verification Process
Release Notes