Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐉🐉 Score multiple tails at once #949

Merged
merged 72 commits into from
Jun 26, 2022
Merged

🐉🐉 Score multiple tails at once #949

merged 72 commits into from
Jun 26, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented May 30, 2022

This PR extends score_{h,r,t} to allow scoring against multiple, but not all, entities/relations at once. This is needed for fast SLCWA (#816), or efficient prediction against a subset of entities/relations.

It also updates predict_{h,r,t} to allow forwarding the respective parameters to score_*.

src/pykeen/models/base.py Outdated Show resolved Hide resolved
src/pykeen/models/base.py Outdated Show resolved Hide resolved
@cthoyt cthoyt requested review from cthoyt and removed request for cthoyt June 23, 2022 00:14
@mberr mberr requested a review from cthoyt June 26, 2022 09:47
@mberr mberr marked this pull request as draft June 26, 2022 10:10
@mberr mberr marked this pull request as ready for review June 26, 2022 10:11
@cthoyt cthoyt requested review from cthoyt and removed request for cthoyt June 26, 2022 11:15
@mberr mberr enabled auto-merge (squash) June 26, 2022 11:26
@cthoyt cthoyt self-requested a review June 26, 2022 11:56
@mberr mberr marked this pull request as draft June 26, 2022 12:43
auto-merge was automatically disabled June 26, 2022 12:43

Pull request was converted to draft

@mberr mberr marked this pull request as ready for review June 26, 2022 12:43
@mberr mberr marked this pull request as draft June 26, 2022 13:40
@mberr mberr marked this pull request as ready for review June 26, 2022 13:41
@mberr mberr merged commit 62220df into master Jun 26, 2022
@mberr mberr deleted the multi-score branch June 26, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants