-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨🤖 Update TransH to ER-Model #954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigger ci
trigger ci
trigger ci
cthoyt
reviewed
Jun 1, 2022
src/pykeen/utils.py
Outdated
@@ -1702,6 +1703,41 @@ def prepare_filter_triples( | |||
return mapped_triples | |||
|
|||
|
|||
def normalize_with_default( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR this into class resolver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
mberr
added a commit
to cthoyt/class-resolver
that referenced
this pull request
Jun 1, 2022
cthoyt
added a commit
to cthoyt/class-resolver
that referenced
this pull request
Jun 1, 2022
cf. pykeen/pykeen#954 Co-authored-by: Charles Tapley Hoyt <cthoyt@gmail.com>
cthoyt
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates TransH to new-style ERModel. Also updates the experiment configuration from JSON to YAML.
It also splits the TransH regularizer into its two components, and modernizes the tests.
Benchmark
FB15k
WN18
FB15k
WN18
Dependencies
normalize_with_defaults