Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敡鉃★笍 Move Nguyen's TransE configurations into correct directory #957

Merged
merged 5 commits into from
Jun 1, 2022
Merged

馃敡鉃★笍 Move Nguyen's TransE configurations into correct directory #957

merged 5 commits into from
Jun 1, 2022

Conversation

PhaelIshall
Copy link
Contributor

@PhaelIshall PhaelIshall commented May 31, 2022

Contributing to bug fixes

Link to the relevant Bug(s)

(#956)

Description of the Change

Simply moved the TransE files to the correct folder in order to be able to reproduce the results

Possible Drawbacks

None

Verification Process

Now able to run:

pykeen experiments reproduce transe nguyen2018 fb15k237
pykeen experiments reproduce transe nguyen2018 wn18rr

Release Notes

  • Moved Transe experiments files for fb15k237 and wn18rr to the correct folder (under transe, previous files were under convkb because they have the same author)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve PyKEEN! 鉂わ笍! 馃帀

@mberr
Copy link
Member

mberr commented May 31, 2022

@PhaelIshall thanks for looking into this.

@PyKEEN-bot test

@mberr mberr changed the title Reproduce Transe Experiments 馃敡鉃★笍 Move Nguyen's TransE configurations into correct directory May 31, 2022
@mberr mberr merged commit 6d96204 into pykeen:master Jun 1, 2022
@mberr
Copy link
Member

mberr commented Jun 1, 2022

Thanks for fixing this @PhaelIshall !

Until our next release, you need to install from git to get the fixed version

pip install git+https://github.com/pykeen/pykeen.git

@mberr mberr mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants