-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃惁馃洃 Early stopping: Reload weights from best epoch #961
Conversation
Tried on the combination with NodePiece on the ILPC'22 small dataset (20 epochs, patience of 3 epochs) - basically works 馃帀 . Ideally, one needs to add a 'normal' path to the EarlyStopper (didn't try it with the pipeline) like stopper = EarlyStopper(
...,
best_model_path="/some/path/temp.pth"
) otherwise it creates a file in the tempdir which results in a hardly every reachable folder like
I am not sure if such temp folder will be automatically cleaned or this file will remain there forever (which is a waste of space). |
Following your suggestion, I
I also
which blows up the diff a bit 馃槄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
This PR re-loads the weights from the best epoch when training is stopped.