Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挜 馃搾 Add troubleshooting for loading old models #963

Merged
merged 9 commits into from
Jun 8, 2022

Conversation

jas-ho
Copy link
Contributor

@jas-ho jas-ho commented Jun 4, 2022

Closes #960

This PR expands the pykeen documentation to describe

  • exceptions users might encounter when attempting to load models trained on a different version of pykeen
  • two things users can try to avoid these exceptions

It includes the main takeaways from #960. The PR is mostly just an attempt to write-up @mberr 's excellent explanations in the mentioned thread.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve PyKEEN! 鉂わ笍! 馃帀

@jas-ho
Copy link
Contributor Author

jas-ho commented Jun 4, 2022

@mberr I was not sure which (if any) of the PR description templates should be used for PRs which update the docs. let me know if the description needs other details. thanks!

@jas-ho jas-ho force-pushed the doc-model-load-across-versions branch from f1bff71 to 21158e8 Compare June 4, 2022 08:16
@cthoyt
Copy link
Member

cthoyt commented Jun 4, 2022

@jas-ho thanks for making this contribution. Team pykeen takes a lot of pride in having excellent documentation so this is much appreciated.

However we might want to rearrange where it鈥檚 living. The first steps document is getting pretty big 馃槄

@jas-ho
Copy link
Contributor Author

jas-ho commented Jun 4, 2022

@jas-ho thanks for making this contribution. Team pykeen takes a lot of pride in having excellent documentation so this is much appreciated.

Thanks, happy to be able to give back to this very cool project!

However we might want to rearrange where it鈥檚 living. The first steps document is getting pretty big sweat_smile

yes, makes total sense. let me hear what your ideas are. one option might be to have a dedicated "trouble shooting" document.

@cthoyt cthoyt changed the title Add documentation on loading models trained on other pykeen versions 馃挜 馃搾 Add troubleshooting for loading old models Jun 8, 2022
@cthoyt
Copy link
Member

cthoyt commented Jun 8, 2022

@PyKEEN-bot test

@cthoyt cthoyt enabled auto-merge (squash) June 8, 2022 08:20
@cthoyt cthoyt disabled auto-merge June 8, 2022 08:25
@cthoyt cthoyt enabled auto-merge (squash) June 8, 2022 08:26
@mberr mberr disabled auto-merge June 8, 2022 19:43
@mberr mberr enabled auto-merge (squash) June 8, 2022 19:43
@mberr mberr merged commit 0f12919 into pykeen:master Jun 8, 2022
@cthoyt
Copy link
Member

cthoyt commented Jun 8, 2022

Thanks @jas-ho !

@mberr mberr mentioned this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load models trained in older pykeen versions
3 participants