Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃搹馃 Add LineaRE interaction #971

Merged
merged 17 commits into from
Jun 9, 2022
Merged

馃搹馃 Add LineaRE interaction #971

merged 17 commits into from
Jun 9, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented Jun 7, 2022 •
edited

Fix #967

also does some cleanup of exports

@mberr mberr changed the title Add LineaRE interaction 馃搹馃 Add LineaRE interaction Jun 8, 2022
@mberr mberr marked this pull request as ready for review June 8, 2022 12:09
@mberr mberr requested a review from cthoyt June 8, 2022 19:06
cthoyt
cthoyt approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough. Do you want to follow up by adding a model?

@mberr
Copy link
Member Author

mberr commented Jun 9, 2022

Good enough. Do you want to follow up by adding a model?

Not necessarily 馃槢

Having support for ERModel via CLI / pipeline would also suffice to define the experimental configuration 馃

@mberr mberr requested a review from cthoyt June 9, 2022 08:13
@mberr mberr enabled auto-merge (squash) June 9, 2022 08:21
@cthoyt
Copy link
Member

cthoyt commented Jun 9, 2022

@mberr needs resolution of conflicts

@mberr mberr disabled auto-merge June 9, 2022 11:58
@mberr mberr enabled auto-merge (squash) June 9, 2022 11:58
@mberr mberr disabled auto-merge June 9, 2022 12:57
@mberr mberr enabled auto-merge (squash) June 9, 2022 12:57
@mberr mberr merged commit fec9fe0 into master Jun 9, 2022
@mberr mberr deleted the add-lineare branch June 9, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt cthoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add LineaRE
2 participants
@mberr @cthoyt