Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥯✔️ Add max_id/shape verification #983

Merged
merged 17 commits into from
Jun 17, 2022
Merged

🥯✔️ Add max_id/shape verification #983

merged 17 commits into from
Jun 17, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented Jun 17, 2022

fix #982

src/pykeen/nn/utils.py Outdated Show resolved Hide resolved
@mberr mberr changed the title Add max_id/shape verification 🥯✔️ Add max_id/shape verification Jun 17, 2022
@mberr mberr marked this pull request as ready for review June 17, 2022 17:48
@mberr mberr requested a review from cthoyt June 17, 2022 17:52
@cthoyt
Copy link
Member

cthoyt commented Jun 17, 2022

I think this looks fine

@mberr mberr merged commit 8e45cff into master Jun 17, 2022
@mberr mberr deleted the max-id-for-everyone branch June 17, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add max_id to all representations
2 participants