Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃洡锔忦煕笍 Add prefix when tracking pipeline metrics #998

Merged
merged 4 commits into from
Jul 4, 2022

Conversation

mberr
Copy link
Member

@mberr mberr commented Jun 28, 2022

This PR logs the evaluation metrics calculated at the end of the pipeline call with an appropriate prefix.

some 1.12 build is already available for cpu, which breaks some CI parts
@mberr mberr enabled auto-merge (squash) June 29, 2022 13:50
@cthoyt
Copy link
Member

cthoyt commented Jun 29, 2022

@mberr @migalkin windows is still complaining :/

@mberr
Copy link
Member Author

mberr commented Jun 29, 2022

But it's complaining in torch_ppr code 馃槄

@cthoyt
Copy link
Member

cthoyt commented Jun 29, 2022

maybe too much specification of argument names as keywords in the unstable api

@mberr
Copy link
Member Author

mberr commented Jun 29, 2022

working on a fix in mberr/torch-ppr#17

@mberr mberr disabled auto-merge June 29, 2022 21:11
@mberr mberr enabled auto-merge (squash) June 29, 2022 21:11
@mberr mberr changed the title Add prefix when tracking pipeline metrics 馃洡锔忦煕笍 Add prefix when tracking pipeline metrics Jun 29, 2022
@mberr
Copy link
Member Author

mberr commented Jun 30, 2022

waiting for rusty1s/pytorch_sparse#244 instead of pinning torch<1.12

@mberr mberr disabled auto-merge July 1, 2022 13:08
@mberr mberr marked this pull request as draft July 1, 2022 13:08
@mberr mberr marked this pull request as ready for review July 1, 2022 13:08
@cthoyt cthoyt requested a review from migalkin July 3, 2022 15:06
Copy link
Member

@migalkin migalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to me, hope the CI pipeline loads all dependencies fine this time

@cthoyt
Copy link
Member

cthoyt commented Jul 4, 2022

so I just made some updates to the issue templates and this problem is now on master, so we can go ahead and merge this while we're waiting to fix that up

@cthoyt cthoyt merged commit b0a9abd into master Jul 4, 2022
@cthoyt cthoyt deleted the fix-prefix branch July 4, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants