remove authconfig support #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't the correct way to remove a command. We have a class for that :) See commit ab95215 for an example. |
|
Thanks for the hint. See new patch. |
bcl
requested changes
Jul 12, 2021
Authconfig compatibility tool (from authselect-compat) will be removed from Fedora 35: https://fedoraproject.org/wiki/Changes/RemoveAuthselectCompatPackage
VladimirSlavik
approved these changes
Jul 13, 2021
|
@pbrezina, I'm curious, why did you make the initial patch just a plain removal of stuff from the handler? The reason to ask is, I re-checked the docs for removing a command and noticed that's mentioned there as the first thing. The "correct new way" is mentioned as an alternative. So if that text was the reason for how this looked, then amending the doc would be a good idea. |
|
Honestly, I was just too lazy and did not check any docs. |
|
Fair enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authconfig compatibility tool (from authselect-compat) will be removed from Fedora 35:
https://fedoraproject.org/wiki/Changes/RemoveAuthselectCompatPackage