Deprecate modularity on Fedora 41 #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure now but I have a feeling that we shouldn't inherit RHEL classes from Fedora ones. @bcl will know better than me. |
|
Usually we want to avoid doing that, changes should always be upstream first when possible but looking at older commits I see we haven't always done that. (I take back what I said about this being ok in this case, see review...) |
bcl
requested changes
May 6, 2024
pykickstart/commands/module.py
Outdated
| @@ -188,3 +188,7 @@ def _getParser(self): | |||
|
|
|||
| """ % versionToLongString(RHEL10)) | |||
| return op | |||
|
|
|||
| class F41_Module(RHEL10_Module): | |||
There was a problem hiding this comment.
This can't inherit from RHEL10, if it does then the deprecation message is going to be wrong.
RHEL messages can reference Fedora since they are based on them, but Fedora cannot reference RHEL, it needs to say it was deprecated in Fedora 41.
To make sure we don't base Fedora off the RHEL, switch it around and define F41 as base where modularity is deprecated and then inherit RHEL10 from it.
|
Fair points, so I change it around. Now F41 is the base where modularity is deprecated and RHEL10 just inherits it. |
KKoukiou
added a commit
to KKoukiou/kickstart-tests
that referenced
this pull request
May 14, 2024
These are already not running as they are disabled, and modularity is deprecated on Fedora-41. So let's just stop running these to clean up the disabled stack. pykickstart/pykickstart#491 Fixes: rhinstaller#769
KKoukiou
added a commit
to KKoukiou/kickstart-tests
that referenced
this pull request
May 15, 2024
These are already not running as they are disabled, and modularity is deprecated on Fedora-41. So let's just stop running these to clean up the disabled stack. pykickstart/pykickstart#491 Fixes: rhinstaller#769
jikortus
pushed a commit
to jikortus/kickstart-tests
that referenced
this pull request
Jun 11, 2024
These are already not running as they are disabled, and modularity is deprecated on Fedora-41. So let's just stop running these to clean up the disabled stack. pykickstart/pykickstart#491 Fixes: rhinstaller#769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.