Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml support chinese and handle voc format #118

Merged
merged 2 commits into from Jul 16, 2023
Merged

Conversation

pizixie
Copy link
Contributor

@pizixie pizixie commented Jul 7, 2023

  1. support unicode(chinese)
  2. handle voc format. ignore "folder" and "filename" node in xml.because they move to other dir sometimes.

…always change dir.

ie:
1. move to other dir
2. change image and label filename pair
@alexheat
Copy link
Contributor

alexheat commented Jul 7, 2023

Thank you @pizixie I will check it out.

@alexheat
Copy link
Contributor

alexheat commented Jul 7, 2023

@pizixie could you possibly provide a sample dataset with the issue that you are addressing with you fix? I want to step through it to make sure that i understand. Thank you

@pizixie
Copy link
Contributor Author

pizixie commented Jul 7, 2023

ok, i will upload some file in tomorrow.

@alexheat
Copy link
Contributor

Hello @pizixie I have cherry picked your commit for the Chinese characters. I still have some questions about the voc commit. Someone else has submitted a similar commit. Could you help to review it and find the best solution?

@pizixie
Copy link
Contributor Author

pizixie commented Jul 16, 2023

0007.zip
hi, I am so sorry, Because too busy in week.
There is a sample dataset with VOC format.
you can see that "file"/"folder"/"path" node in xml file.
while "path" is incorrect.

@pizixie
Copy link
Contributor Author

pizixie commented Jul 16, 2023

oh...oh...speak chinese.
标注与图片名字相同,后缀不同。这才是简单的关联方式。
很多工具在这些字段中随意记录信息,太混乱了,并且文件还不能移动。

@pizixie
Copy link
Contributor Author

pizixie commented Jul 16, 2023

Hello @pizixie I have cherry picked your commit for the Chinese characters. I still have some questions about the voc commit. Someone else has submitted a similar commit. Could you help to review it and find the best solution?

我恐怕没有时间去检查这些commit

@alexheat
Copy link
Contributor

Thank you! But I don't speak Chinese :)

@alexheat alexheat merged commit 83a42a0 into pylabel-project:dev Jul 16, 2023
1 check passed
@alexheat
Copy link
Contributor

Thank you @pizixie I have merged your pull request and released it in v52 https://github.com/pylabel-project/pylabel/releases/tag/v0.1.52

@pizixie
Copy link
Contributor Author

pizixie commented Jul 17, 2023

ok,I will test it in future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants