Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent maximum recursion RuntimeError caused by Tox #158

Merged
merged 4 commits into from Dec 10, 2015

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 10, 2015

Travis CI has started failing -- not due to Last.fm's APIs being broken after they relaunched ("re-imagined") their site -- but due to RuntimeError: maximum recursion depth exceeded. For example:

  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 913, in _replace_env
    env_list = self.getdict('setenv')
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 839, in getdict
    s = self.getstring(name, None)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 893, in getstring
    x = self._replace(x)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 993, in _replace
    return RE_ITEM_REF.sub(self._replace_match, x)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 989, in _replace_match
    return handler(match)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 913, in _replace_env
    env_list = self.getdict('setenv')
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 839, in getdict
    s = self.getstring(name, None)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/tox/config.py", line 880, in getstring
    x = self._cfg[s][name]
RuntimeError: maximum recursion depth exceeded

This happens for all Python versions. One of the Python packages that has changed since this last worked is Tox, which is now at 2.2.1. The last working build used Tox 2.1.1. So let's fix Tox at 2.1.1 (and later report this to Tox or Travis CI).

@hugovk
Copy link
Member Author

hugovk commented Dec 10, 2015

Tox already know about their bug and have a fix underway: https://bitbucket.org/hpk42/tox/issues/285/tox-220-breaks-some-toxini-config-files

hugovk added a commit that referenced this pull request Dec 10, 2015
Prevent maximum recursion RuntimeError caused by Tox
@hugovk hugovk merged commit f75a29e into pylast:develop Dec 10, 2015
@hugovk hugovk deleted the travis_infinite branch December 10, 2015 09:43
hugovk added a commit that referenced this pull request Sep 19, 2017
@hugovk hugovk mentioned this pull request Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant