Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to authenticate with a session key #421

Merged
merged 3 commits into from Jan 6, 2023
Merged

Document how to authenticate with a session key #421

merged 3 commits into from Jan 6, 2023

Conversation

ndm13
Copy link
Contributor

@ndm13 ndm13 commented Jan 2, 2023

Describe authentication with OAuth token

Fixes #417

Describe authentication with OAuth token
@adammpkins
Copy link

+1 for this PR

@hugovk
Copy link
Member

hugovk commented Jan 5, 2023

Thanks for the PR!

I've made an edit to put the alternatives in their own code blocks, to try and make it a bit clearer. How does this look?

https://github.com/ndm13/pylast/blob/patch-1/README.md#getting-started

@hugovk hugovk added docs Documentation changelog: Changed For changes in existing functionality labels Jan 5, 2023
@hugovk hugovk changed the title Add code from pylast #407 to readme Document how to authenticate with a session key Jan 5, 2023
@ndm13
Copy link
Contributor Author

ndm13 commented Jan 5, 2023

I like splitting it up, but I think either the import and API info should be a separate block or it should be in both blocks. I'm picturing people copying and pasting and being annoyed.

@hugovk
Copy link
Member

hugovk commented Jan 6, 2023

Good idea, updated!

@hugovk
Copy link
Member

hugovk commented Jan 6, 2023

Thank you!

@hugovk hugovk merged commit 7f07bab into pylast:main Jan 6, 2023
@ndm13 ndm13 deleted the patch-1 branch January 6, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oauth authentication
3 participants