Move TabIndex's enable/disable logic to separate class

pylbrecht · Jul 7, 2024 · 61834b9 · 61834b9
1 parent 2c05e9f
commit 61834b9
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/qutebrowser/mainwindow/mainwindow.py b/qutebrowser/mainwindow/mainwindow.py
@@ -525,7 +525,7 @@ def _connect_signals(self):
         self.tabbed_browser.cur_scroll_perc_changed.connect(
             self.status.percentage.widget.set_perc)
         self.tabbed_browser.widget.tab_index_changed.connect(
-            self.status.tabindex.on_tab_index_changed)
+            self.status.tabindex.widget.on_tab_index_changed)
 
         self.tabbed_browser.cur_url_changed.connect(
             self.status.url.widget.set_url)

diff --git a/qutebrowser/mainwindow/statusbar/bar.py b/qutebrowser/mainwindow/statusbar/bar.py
@@ -184,7 +184,7 @@ def __init__(self, *, win_id, private, parent=None):
         self.url = url.UrlText(widget=url.UrlTextWidget())
         self.percentage = percentage.Percentage(widget=percentage.PercentageWidget())
         self.backforward = backforward.Backforward(widget=backforward.BackforwardWidget())
-        self.tabindex = tabindex.TabIndex()
+        self.tabindex = tabindex.TabIndex(widget=tabindex.TabIndexWidget())
         self.keystring = keystring.KeyString(widget=keystring.KeyStringWidget())
         self.prog = progress.Progress(widget=progress.ProgressWidget(self))
         self.clock = clock.Clock(widget=clock.ClockWidget())
@@ -277,7 +277,7 @@ def _clear_widgets(self):
         """Clear widgets before redrawing them."""
         # Start with widgets hidden and show them when needed
         for widget in [self.url.widget, self.percentage.widget,
-                       self.backforward.widget, self.tabindex,
+                       self.backforward.widget, self.tabindex.widget,
                        self.keystring.widget, self.prog.widget, self.clock.widget, *self._text_widgets]:
             assert isinstance(widget, QWidget)
             if widget in [self.prog.widget, self.backforward.widget]:

diff --git a/qutebrowser/mainwindow/statusbar/tabindex.py b/qutebrowser/mainwindow/statusbar/tabindex.py
@@ -9,11 +9,22 @@
 from qutebrowser.mainwindow.statusbar import textbase
 
 
-class TabIndex(textbase.TextBase):
+class TabIndexWidget(textbase.TextBase):
 
     """Shows current tab index and number of tabs in the statusbar."""
 
     @pyqtSlot(int, int)
     def on_tab_index_changed(self, current, count):
         """Update tab index when tab changed."""
         self.setText('[{}/{}]'.format(current + 1, count))
+
+
+class TabIndex:
+    def __init__(self, widget: TabIndexWidget):
+        self.widget = widget
+
+    def enable(self):
+        self.widget.show()
+
+    def disable(self):
+        self.widget.hide()