Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.Message.__init__, is_extended_id vs extended_id #29

Closed
ericevenchick opened this issue Jun 5, 2020 · 4 comments
Closed

can.Message.__init__, is_extended_id vs extended_id #29

ericevenchick opened this issue Jun 5, 2020 · 4 comments

Comments

@ericevenchick
Copy link

I'm having trouble using python-can-isotp with python-can. tx_canbus attempts to create a new can.Message using the extended_id keyword argument, but this has been changed to is_extended_id.

The issue is at

self.bus.send(can.Message(arbitration_id=msg.arbitration_id, data = msg.data, extended_id=msg.is_extended_id, is_fd=msg.is_fd))

It seems like a simple one line fix, but I'm not sure if I using the wrong version or doing something else to cause this error.

@pylessard
Copy link
Owner

pylessard commented Jun 5, 2020

You are right, the parameter indeed has been changed.
I will update the library tonight

Thank you!

image

@pylessard
Copy link
Owner

Can you try the fix I just pushed?

@pylessard pylessard reopened this Jun 5, 2020
@ericevenchick
Copy link
Author

Looks like it works now, thanks for the quick fix!

@pylessard
Copy link
Owner

Fix published in v1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants