Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to switch off Flow Control sending on Rx #59

Closed
toooooobi opened this issue Feb 1, 2022 · 3 comments · Fixed by #65
Closed

Possibility to switch off Flow Control sending on Rx #59

toooooobi opened this issue Feb 1, 2022 · 3 comments · Fixed by #65
Projects

Comments

@toooooobi
Copy link

I have some projects where it is not necessary to send a flow control after reception of first frame
In my case another ECU is taking care of that.

Proposal: Implement a parameter to switch off flow control on reception, e.g.
image

@pylessard pylessard reopened this Feb 6, 2022
@pylessard pylessard added this to Todo in v1.8 Feb 6, 2022
@pylessard pylessard moved this from Todo to In Progress in v1.8 Feb 6, 2022
@pylessard
Copy link
Owner

Hi
I'd like to take care of this modification as I'd like it to be unit tested and documented.

Do you need to transmit with your stack? I was thinking about disabling completely transmission in Listen Mode.
Any opinion?

Thank you

@toooooobi
Copy link
Author

toooooobi commented Feb 16, 2022

Hi Pierre,

actually the idea was to be able to transmit still, but having the option to turn off automatic sending of FC frames in case FF rx.

Is this also possible with the socket configuration?

Thank you.

@pylessard
Copy link
Owner

Fixed with Pull Request #65

pylessard added a commit that referenced this issue Mar 6, 2022
#59 - Support Listen Mode where no Flow Control is sent.
@pylessard pylessard moved this from In Progress to Done in v1.8 Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.8
Done
Development

Successfully merging a pull request may close this issue.

2 participants