Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse request/response from payload success depends on module loading order #158

Merged
merged 2 commits into from
May 25, 2023

Conversation

pylessard
Copy link
Owner

Since V1.17,
The BaseService class has been moved out of the services module, causing the get_subclass function to fail if the services module has not been loaded prior to the call.
Fix now forces an explicit load of the services submodule before using subclass properties.

@pylessard
Copy link
Owner Author

@trd1st want to try this PR?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm, that this resolves the issue on my side.

@pylessard pylessard merged commit 272569e into master May 25, 2023
@pylessard pylessard deleted the request_reponse_subclass_not_loaded branch August 8, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant