Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated astroid.node_classes and astroid.scoped_nodes #1072

Closed
Pierre-Sassoulas opened this issue Jun 23, 2021 · 2 comments · Fixed by #2300 or #2303
Closed

Remove deprecated astroid.node_classes and astroid.scoped_nodes #1072

Pierre-Sassoulas opened this issue Jun 23, 2021 · 2 comments · Fixed by #2300 or #2303
Assignees
@jacobtylerwalls
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Milestone
3.0.0b0

Comments

@Pierre-Sassoulas
Copy link
Member

Those two files have been deprecated in 2.7.0 and need to be removed in 3.0.0.
@Pierre-Sassoulas Pierre-Sassoulas added task Maintenance Discussion or action around maintaining astroid or the dev workflow labels Jun 23, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0 milestone Jun 23, 2021
@Pierre-Sassoulas Pierre-Sassoulas changed the title Remove deprecated astroid.node_classes and astroid.scoped_nodes`` Remove deprecated astroid.node_classes and astroid.scoped_nodes Jun 23, 2021
@belm0
Copy link
Contributor

belm0 commented Sep 23, 2021 •
edited

astroid seems to be triggering its own deprecation warnings, which is quite annoying for projects trying to maintain a warning-free runtime

https://github.com/PyCQA/astroid/blob/4ffdf1108a6084b85e282b5835427c1d747bb22c/astroid/__init__.py#L54-L55

  File "/.../site-packages/astroid/__init__.py", line 54, in <module>
    from astroid import node_classes  # Deprecated, to remove later
  File "/.../site-packages/astroid/node_classes.py", line 90, in <module>
    warnings.warn(
DeprecationWarning: The 'astroid.node_classes' module is deprecated and will be replaced by 'astroid.nodes' in astroid 3.0.0

@Pierre-Sassoulas Pierre-Sassoulas self-assigned this Sep 23, 2021
Pierre-Sassoulas added a commit that referenced this issue Sep 25, 2021
@Pierre-Sassoulas
Remove deprecation warning raised by own astroid code
2ff5be0 
Following comment here: #1072
Pierre-Sassoulas added a commit that referenced this issue Sep 25, 2021
@Pierre-Sassoulas
Remove deprecation warning raised by own astroid code
d9fcae5 
Following comment here: #1072
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Sep 25, 2021
Merged
@Pierre-Sassoulas
Copy link
Member Author

@belm0 thank you for the coment, I opened #1190 to fix that, should be available in 2.8.1.

Pierre-Sassoulas added a commit that referenced this issue Sep 25, 2021
@Pierre-Sassoulas
Remove deprecation warning raised by own astroid code (#1190)
49b1411 
Following comment here: #1072
@cdce8p cdce8p modified the milestones: 3.0.0a1, 3.0.0a2, 3.0.0a3 Apr 25, 2023
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.0.0a3, 3.0.0a4 May 14, 2023
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.0.0a4, 3.0.0a5, 3.0.0a6 Jun 6, 2023
@jacobtylerwalls jacobtylerwalls modified the milestones: 3.0.0a6, 3.0.0b0 Jul 4, 2023
@jacobtylerwalls jacobtylerwalls removed this from the 3.1 milestone Sep 23, 2023
@jacobtylerwalls jacobtylerwalls mentioned this issue Sep 23, 2023
Merged
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0 milestone Sep 24, 2023
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
3.0.0b0
4 participants
@belm0 @Pierre-Sassoulas @cdce8p @jacobtylerwalls