Add node_ancestors method #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
cdce8p
requested changes
Sep 13, 2021
|
There should also be a |
nickdrozd
force-pushed
the
node-ancestors
branch
from
f4ccfda
to
0305013
Compare
I've been thinking about ways to get rid of unbounded `while` loops in the Pylint codebase. A common use is to loop over a node's ancestors. The `node_ancestors` method centralizes this logic in one place so that those `while` loops can be rewritten as `for`. A few uses are made of this new method. It only comes up a few places in Astroid, but there are many more in Pylint.
nickdrozd
force-pushed
the
node-ancestors
branch
from
0305013
to
776004d
Compare
cdce8p
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Looks good!
As explained earlier, with the name conflict I would just leave it at node_ancestors.
--
@nickdrozd Just a small note. Could you please not force-push any new changes in future PRs? That will make reviewing them more difficult. In the end we can always squash merge them.
Pierre-Sassoulas
approved these changes
Sep 13, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking about ways to get rid of unbounded
whileloops inthe Pylint codebase. A common use is to loop over a node's ancestors.
The
node_ancestorsmethod centralizes this logic in one place sothat those
whileloops can be rewritten asfor.A few uses are made of this new method. It only comes up a few places
in Astroid, but there are many more in Pylint.
Type of Changes